Skip to content

refactor(loader-client): the manifest version is read from public/version in the cwd and nothing uses it #145

Open

Description

@Exeloo

Which app is this feature request for?

client

Feature

Since the per-file hashes (#8), the website never reads manifest.version. The client still computes it on every /manifest request (manifest.ts#L9-L20):

  • it reads public/version relative to the process cwd, not the game dir, so a stray file there would freeze the value;
  • otherwise it fingerprints every file hash.

This is dead logic, and the docs still describe it (client.mdx#L37, website README.md#L51).

Found during a read-only audit of main @ 044c766 (2026-11-11).

Ideal solution or implementation

Remove version from the manifest and its types (apps/client/src/server.ts, apps/website/src/types/manifest.type.ts), and update the docs.

Alternative solutions or implementations

Keep version, but use it in the website as a cheap cache key before checking each file hash, and compute it from the game dir instead of the cwd.

Other context

No response

Activity

  1. added
    enhancementNew feature or request
    app:clientRelated to client app
    app:websiteRelated to website app
    refactorCode change that neither fixes a bug nor adds a feature
    on Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    app:clientRelated to client appapp:websiteRelated to website appenhancementNew feature or requestrefactorCode change that neither fixes a bug nor adds a feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions