Repository navigation
Show an organization's page with its commits and mentions, as the web does - #150
Merged
Merged
Conversation
… does
Organizations can now post commits, and tapping one's name on its commit
opened it as a user, which devnull doesn't have: "No query results for
model [App\Models\User]". A commit's author now says whether it's an
organization, and its name opens the organization's page.
That page was a placeholder saying organization pages are new. It's now
laid out like the web's: the avatar as a rounded square ringed in its
lane, Share and Follow, the handle marked Organization, what GitHub says
about it, how many follow it and its admins, three to a line, each
opening their profile. Below are its Commits and the commits that
mention it, as pages you swipe between, as on a profile.
Commits needs devnull's new organizations/{handle}/commits. Until a
server has it, that tab says it didn't load, with the page on the web a
tap away, and the header and Mentions carry on.
Follow changes straight away, puts itself back if devnull says no, and
moves the kept page's count with it. Share opens the share sheet with
the page on the web, in Lucide's share-2 as the web draws it. An
organization whose admins haven't picked a lane is in Commit Blue on
its page and its commits, as the web's organizationLaneColor() draws
it, where both used to hash a different id into different lanes. Only
GitHub handles its bio mentions open, as on a profile.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organizations can now post commits, and tapping one's name on its commit opened it as a user, which devnull doesn't have. The app showed "No query results for model [App\Models\User] dev-null.sh". A commit's author now says whether it's an organization, and its name opens the organization's page.
That page was a placeholder saying organization pages are new. It's now laid out like the web's:
share-2as the web draws it.organizationLaneColor()draws it. Both used to hash a different id, so they came out in different lanes.The Commits tab needs devnull's new
organizations/{handle}/commits, in dev-null-sh/dev-null.sh#1386. Until a server has it, that tab says it didn't load, with the page on the web a tap away, and the header and Mentions carry on.Tests:
OrganizationTestcovers the page, both tabs, a tab failing on its own, follow and its refusal, share, admins, bio mentions and the lane.LogTestcovers opening an organization from its commit, andResponseCacheTestthe kept page's follow. Locally, the organization, data andDevnulltests pass, 262 with 1 skipped, and so do the unit tests, 269.Checked on a Pixel 9 (Android 16, hardware): against dev-null.sh, the header and Mentions load and Commits says it didn't load. Against #1386 served locally, with dev-null.sh copied from its public page, the Commits tab shows its commit.
Screenshots
organization
The after shots are against #1386 served locally. The organization there has no lane picked, so it's in Commit Blue; on dev-null.sh it's orange. iOS isn't here because Xcode isn't installed on this machine.