Repository navigation
feat: intent for "wake me" - #145
Merged
Merged
Conversation
mikejgray
force-pushed
the
FEAT_WakeMeIntent
branch
from
October 29, 2024 03:39
fc553f3 to
02543db
Compare
NeonDaniel
requested changes
Oct 29, 2024
NeonDaniel
requested changes
Sep 23, 2026
NeonDaniel
left a comment
NeonDaniel
left a comment
Member
There was a problem hiding this comment.
Suggested updates to the test cases. Also needs a rebase on dev
…e assertion
- Replace {time} placeholders in intent tests with real utterances
- Add uk-ua wake_me.intent and matching test phrases (uk-ua locale
landed on dev after this branch was cut)
- Fix test_wake_me_intent: alarms are named by clock time, not duration
mikejgray
force-pushed
the
FEAT_WakeMeIntent
branch
from
September 23, 2026 00:17
da78958 to
4627a5e
Compare
NeonDaniel
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for "wake me" style intents for alarms.
Issues
Closes #119
Other Notes
I had some odd test results locally on my Macbook, hoping CI will be more forgiving