Repository navigation
fix: stabilize net_route_interface_labels series across polls - #4485
Merged
Merged
Conversation
The NetRoute plugin keyed each interface instance with a counter that incremented while ranging over a map, so the exported index label changed every poll. On one cluster, 5,515 of 5,547 series had a different index between two pollers scraped at the same time. Every poll created new Prometheus series, causing cardinality churn and breaking continuity. Key instances by route uuid and interface name instead, and stop exporting index. It was never used by a dashboard, and route_uuid plus the interface labels already make each series unique. uuid and route_uuid are unchanged. A duplicate interface name within a route is now logged and skipped instead of failing the whole poll.
rahulguptajss
approved these changes
Sep 28, 2026
Hardikl
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NetRoute plugin keyed each interface instance with a counter that incremented while ranging over a map, so the exported index label changed every poll. On one cluster, 5,515 of 5,547 series had a different index between two pollers scraped at the same time. Every poll created new Prometheus series, causing cardinality churn and breaking continuity.
Key instances by route uuid and interface name instead, and stop exporting index. It was never used by a dashboard, and route_uuid plus the interface labels already make each series unique. uuid and route_uuid are unchanged.
A duplicate interface name within a route is now logged and skipped instead of failing the whole poll.