Repository navigation
Improve docstings of OpenEphysBinaryRawIO - #1774
Merged
alejoe91 merged 6 commits intoOct 6, 2025
Merged
Conversation
h-mayorquin
marked this pull request as ready for review
September 12, 2025 22:45
Contributor
|
I think this looks pretty great. The diff is huge since the functions are split so it'll take a moment to review :) |
alejoe91
self-requested a review
September 19, 2025 13:29
alejoe91
approved these changes
Oct 6, 2025
alejoe91
left a comment
Contributor
There was a problem hiding this comment.
Nice rewrite @h-mayorquin! This added docs will make it much easier to maintain for us too! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on fixing a neuroconv issue, I noticed that the
OpenEphysBinaryRawIOclass lacks clear documentation about how the folder structure of the Open Ephys binary format is parsed and use internally.This PR improves the situation in two ways:
The docstring now more explicitly describes the type of structure being parsed and clarifies that
dirnamecan point to different levels within the folder tree, each yielding different parsing results.The current
explore_folderfunction mixes two responsibilities:To separate concerns, I split this logic into two private functions. Each now has a dedicated docstring that clearly explains its role. There is no change in implementation the function is just split in two.