Skip to content

Ensure the preferredChildFocusKey is actually a descendant of the target focus key - #247

Merged
xavi160 merged 2 commits into
mainfrom
ensure-preferred-child-is-related
Sep 25, 2026
Merged

xavi160 merged 2 commits into
mainfrom
ensure-preferred-child-is-related

Conversation

@xavi160

@xavi160 xavi160 commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator
  • Prevent preferredChildFocusKey from moving focus outside the current target’s subtree.
  • Add an ancestor-chain check before selecting the preferred child.

@xavi160 xavi160 self-assigned this Sep 25, 2026
@xavi160
xavi160 requested a review from a team as a code owner September 25, 2026 10:09
@changeset-bot

changeset-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9202846

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@noriginmedia/norigin-spatial-navigation-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

KevisLeL
KevisLeL previously approved these changes Sep 25, 2026

@KevisLeL KevisLeL left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

predikament
predikament previously approved these changes Sep 25, 2026

@predikament predikament left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavi160
xavi160 dismissed stale reviews from predikament and KevisLeL via 9202846 September 25, 2026 10:21
@xavi160
xavi160 merged commit 62bb920 into main Sep 25, 2026
1 check passed
@xavi160
xavi160 deleted the ensure-preferred-child-is-related branch September 25, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants