Repository navigation
Add overall timeout for peer downloads - #38
Merged
Merged
Conversation
tripledoublev
force-pushed
the
add-download-overall-timeout
branch
from
June 9, 2026 15:24
023a296 to
9a0ed27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Group::download_hash_from_peers_with_timeoutso callers can bound the total peer-download request budgetGroup::download_hash_from_peersas the existing no-overall-timeout wrapper for compatibilitysave-dweb-backendto0.3.9Verification
cargo checkcargo test download_hash_from_peers_test -- --nocapturegit diff --checkNotes
This lets
save-rustdelete its local media-specific peer-download copy while keeping the Android-facing overall media download budget.