Repository navigation
fix(prompted-generator): propagate serving failures - #544
Open
rikkurea-boop wants to merge 2 commits into
Open
rikkurea-boop wants to merge 2 commits into
rikkurea-boop wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagate failures from
PromptedGenerator's serving backend instead of logging and silently returning.Problem
PromptedGenerator.run()catches exceptions raised by:llm_serving.generate_from_input(...)but currently logs the error and returns normally.
This makes a failed generation look like a successful operator run to callers and orchestration code.
Fix
Keep the existing error logging, but re-raise the serving exception.
The production change is intentionally minimal: