Skip to content

fix(prompted-generator): propagate serving failures - #544

Open
rikkurea-boop wants to merge 2 commits into
OpenDCAI:mainfrom
rikkurea-boop:publish/p09-04-prompted-generator-failure-propagation
Open

rikkurea-boop wants to merge 2 commits into
OpenDCAI:mainfrom
rikkurea-boop:publish/p09-04-prompted-generator-failure-propagation

Conversation

@rikkurea-boop

Copy link
Copy Markdown
Contributor

Summary

Propagate failures from PromptedGenerator's serving backend instead of logging and silently returning.

Problem

PromptedGenerator.run() catches exceptions raised by:

llm_serving.generate_from_input(...)

but currently logs the error and returns normally.

This makes a failed generation look like a successful operator run to callers and orchestration code.

Fix

Keep the existing error logging, but re-raise the serving exception.

The production change is intentionally minimal:

except Exception as e:
    self.logger.error(f"Error during text generation: {e}")
    raise

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant