Repository navigation
Bump FreeMarker to 2.3.35 and fix the loadObjectClassesToMaps javadoc - #1176
Merged
vharseko merged 1 commit intoOct 6, 2026
Conversation
CVE-2026-84939 (code scanning alert 1297): FreeMarker before 2.3.35 resolves a malformed locale identifier into a path outside the template root. OpenDJ only renders its own templates, for the generated documentation, so it is not reachable, but the jar ships in lib/. The javadoc of CompressedSchema.loadObjectClassesToMaps listed a "sync" parameter the method does not have and documented "mappings" twice, with the encode and decode maps the wrong way round (alert 1281).
vharseko
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two code scanning alerts on
master.Alert 1297: FreeMarker 2.3.34 → 2.3.35 (CVE-2026-84939)
FreeMarker before 2.3.35 resolves a malformed locale identifier into a path outside the template root. Trivy reports it on
opt/opendj/lib/org.freemarker.freemarker.jarof the image built frommaster(trivy-build-alpine).In OpenDJ it is not reachable: FreeMarker only renders OpenDJ's own templates, in
DocGenerationHelper(opendj-cli) and the doc maven plugin, and nothing takes a locale from a client. The jar ships inlib/all the same, so the alert stays open until the version moves. commons made the same bump in OpenIdentityPlatform/commons#311.All three
Configurationinstances are built withConfiguration.DEFAULT_INCOMPATIBLE_IMPROVEMENTS, a fixed constant, so the template behaviour does not follow the library version.Alert 1281:
CompressedSchema.loadObjectClassesToMapsjavadocThe javadoc listed a
syncparameter the method does not have (left over from #920) and documentedmappingstwice, with the encode and decode maps the wrong way round.Not in this PR
jackson.version,netty-bom), so they belong in a commons change and acommons.versionbump.trivy-image-*alerts are on the published 5.1.2 image;masteralready carries the fixed versions (bc-fips 2.1.3, jackson 2.18.9, postgresql 42.7.12, mssql-jdbc 13.4.0, a fresh base image). They close with the next release.Testing
mvn -pl opendj-cli,opendj-doc-maven-plugin -am package -DskipTestsbuilds with 2.3.35. The documentation generation itself runs in CI.