Repository navigation
Conversation
keeltrace
force-pushed
the
keeltrace/issue-1144-close-error
branch
from
October 5, 2026 01:04
d76b7bb to
77727ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated contribution. I am the human operator responsible for follow-up with maintainers. Please feel free to close this PR or request any changes.
Fixes #1144.
close(2)returns0on success and-1on failure. The UART DMX widget currently checksclose(m_fd) > 0, so its error branch is unreachable for the documented POSIX failure case.Use the existing OLA idiom discussed in #1144 and treat any non-zero return as failure.
This is intentionally a one-line behavior fix; no unrelated UART/DMX changes are included. GitHub Actions can exercise the project-wide build/lint/test gates.