Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #555
Problem
The MambaTab pages still described the behaviour of every release before 2.1.0, where
MambaTab.forwardskipped its Mamba block. 83508ee ("fix(architectures): apply the Mamba block in MambaTab.forward", released in 2.1.0) wired the block in, but the docs kept saying:forward";mamba_version"has no effect in the current release";axisis a "Temporary unsqueeze axis before normalization".Change
Docs only:
docs/model_zoo/stable/mambatab.md: the overview, forward steps, diagram, building-blocks table and implementation notes now include the Mamba block and explain the length-one-sequence (axis=1) vs. batch-as-sequence (axis=0) layout. A short note says that releases before 2.1.0 (and the earliermambularpackage) skipped the block, so older MambaTab results describe a projected-feature network.n_layers,d_stateandexpand_factor, and explains thataxis=0scans the rows of a batch as one sequence, so a row's prediction depends on the rows before it in the batch.docs/model_zoo/stable/index.md: the recommendation describes MambaTab as a compact Mamba baseline over one projected token per row.Verification
A forward hook on
MambaTab.mambafires with input shape(batch, 1, d_model)onmain. The defaults in the table matchMambaTabConfig(n_layers=1,d_state=128,expand_factor=2), and v2.0.0, v1.8.0 andmambularv1.3.2-v1.5.0 never callself.mambainforward.Checks
just test: 3236 passed, 46 skipped, 28 xfailed; coverage 91.29%just docs: build succeeded (warnings treated as errors)just check: all hooks passed (ruff, prettier, pyright)