Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 15, 2026
pepebndc
force-pushed
the
refactor/math-10-uint128-max
branch
from
October 15, 2026 06:22
a3c53b9 to
8a3d6bd
Compare
Utils.UINT128_MAX carried a TODO to remove it once a math module provides the constant. Uint128.MAX_UINT128 now returns the same Uint<128> value. Mark Utils.UINT128_MAX as deprecated and point to it. Doc comment only: the circuit, its callers in token and multisig, and their ZKIR do not change. Add the CHANGELOG line and the guide mentions.
pepebndc
force-pushed
the
refactor/math-10-uint128-max
branch
from
October 15, 2026 09:25
8a3d6bd to
478abbc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 10 of 13 of the math library migration from midnight-apps
contracts/src/math. Refs #213.Stack: #1125 → #1126 → #1127 → #1128 → #1140 → #1141 → #1142 → #1143 → #1144 → #1145 → #1146 → #1147 → #1148. Merge in order.
Summary
Utils.UINT128_MAXwas a stand-in until a math module had the constant. It is now deprecated in favor ofUint128.MAX_UINT128, which returns the same value and type. Doc comment only: the circuit and its callers in token and multisig do not change.Changes
@deprecatednote, the CHANGELOG line under Deprecated and the guide mentions (478abbc0).Validation
Types of changes
PR Checklist