Skip to content

chore: use pages-staging-scoped role for PR previews - #77

Merged
John McCall (lowlydba) merged 1 commit into
mainfrom
lowlydba-use-scoped-role-pr-previews
Nov 4, 2026
Merged

John McCall (lowlydba) merged 1 commit into
mainfrom
lowlydba-use-scoped-role-pr-previews

Conversation

@lowlydba

@lowlydba John McCall (lowlydba) commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Resolves #76

Switches PR previews to the pages-staging-scoped-oidc-overturemaps role and adds environment: staging to the cleanup job (the deploy job already had it). The scoped role only trusts jobs in the staging environment.

Depends on OvertureMaps/omf-core-data-opentofu#149 being applied for the role to exist.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Signed-off-by: John McCall <john@overturemaps.org>
@lowlydba
John McCall (lowlydba) force-pushed the lowlydba-use-scoped-role-pr-previews branch from c231e0b to 07e3a23 Compare November 4, 2026 15:03
@lowlydba John McCall (lowlydba) changed the title ci: use pages-staging-scoped role for PR previews chore: use pages-staging-scoped role for PR previews Nov 4, 2026
@lowlydba
John McCall (lowlydba) marked this pull request as ready for review November 4, 2026 15:06
@lowlydba
John McCall (lowlydba) requested a review from a team as a code owner November 4, 2026 15:06
Copilot AI balanced review requested due to automatic review settings November 4, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The prerequisite IAM PR #149 was inaccessible, leaving the scoped role’s trust policy and permissions unverified and requiring confirmation that the infrastructure is applied and preview deployment and cleanup work with the role.

No open issues 🎉

What changed in this PR

Moves PR preview deployment and cleanup to the scoped AWS OIDC role, limiting access to this repository’s preview prefix in the staging bucket. Requires OvertureMaps/omf-core-data-opentofu#149 to be applied.

Changes:

  • Uses pages-staging-scoped-oidc-overturemaps in both workflows.
  • Adds environment: staging to cleanup to satisfy the role’s trust requirements.
File Description
.github/​workflows/​staging_deploy.yml Switches preview deployment to the scoped role.
.github/​workflows/​staging_deploy_cleanup.yml Switches cleanup to the scoped role and declares the staging environment.

Review effort: Balanced

@lowlydba
John McCall (lowlydba) merged commit 875a6af into main Nov 4, 2026
11 of 12 checks passed
@lowlydba
John McCall (lowlydba) deleted the lowlydba-use-scoped-role-pr-previews branch November 4, 2026 18:49

This branch was previously deployed

1 inactive deployment
staging — 07e3a23a Deployed Nov 4, 2026 by lowlydba via Cleanup #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move PR previews to the pages-staging-scoped OIDC role

3 participants