Repository navigation
chore: use pages-staging-scoped role for PR previews - #77
Merged
Merged
Conversation
John McCall (lowlydba)
had a problem deploying
to
staging
November 4, 2026 15:03 — with
GitHub Actions
Error
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
force-pushed
the
lowlydba-use-scoped-role-pr-previews
branch
from
November 4, 2026 15:03
c231e0b to
07e3a23
Compare
John McCall (lowlydba)
had a problem deploying
to
staging
November 4, 2026 15:04 — with
GitHub Actions
Failure
John McCall (lowlydba)
marked this pull request as ready for review
November 4, 2026 15:06
There was a problem hiding this comment.
🔵 Needs a closer look
The prerequisite IAM PR #149 was inaccessible, leaving the scoped role’s trust policy and permissions unverified and requiring confirmation that the infrastructure is applied and preview deployment and cleanup work with the role.
No open issues 🎉
What changed in this PR
Moves PR preview deployment and cleanup to the scoped AWS OIDC role, limiting access to this repository’s preview prefix in the staging bucket. Requires OvertureMaps/omf-core-data-opentofu#149 to be applied.
Changes:
- Uses
pages-staging-scoped-oidc-overturemapsin both workflows. - Adds
environment: stagingto cleanup to satisfy the role’s trust requirements.
| File | Description |
|---|---|
.github/workflows/staging_deploy.yml |
Switches preview deployment to the scoped role. |
.github/workflows/staging_deploy_cleanup.yml |
Switches cleanup to the scoped role and declares the staging environment. |
Review effort: Balanced
Alex Iannicelli (atiannicelli)
approved these changes
Nov 4, 2026
John McCall (lowlydba)
deleted the
lowlydba-use-scoped-role-pr-previews
branch
November 4, 2026 18:49
John McCall (lowlydba)
temporarily deployed
to
staging
November 4, 2026 18:49 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #76
Switches PR previews to the
pages-staging-scoped-oidc-overturemapsrole and addsenvironment: stagingto the cleanup job (the deploy job already had it). The scoped role only trusts jobs in the staging environment.Depends on OvertureMaps/omf-core-data-opentofu#149 being applied for the role to exist.