Repository navigation
fix(generate): unseeded generators repeated values across messages - #46
Merged
Merged
Conversation
Unseeded runs seeded the n-th generator of a context `base + conn_seq`;
Gen::new forces `seed | 1`, so every even/odd pair of consecutive
generators got the same stream. Step 2 of iteration N therefore repeated
step 1 of iteration N+1 — `${uuid}` and `@std/random` included — and a
create-by-unique-name test (Kubernetes CRs) hit 409 Conflict from the
second iteration on. Adjacent xorshift seeds also shared output prefixes.
Unseeded seeds now go through the same derive_seed hash as seeded runs,
over one random base per context.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Anthropic Claude <noreply@anthropic.com>
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Anthropic Claude <noreply@anthropic.com>
This was referenced Nov 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unseeded runs seeded the n-th generator
base + conn_seq;Gen::newforcesseed | 1, so each even/odd pair of consecutive generators shared one stream: step 2 of iteration N repeated step 1 of iteration N+1 (${uuid}and@std/randomalike). Found migrating a Kubernetes CR benchmark — every iteration after the first got 409 Conflict on create.Fix: unseeded seeds go through the same
derive_seedhash as seeded runs (one random base per context). Seeded runs unchanged. Regression testunseeded_generators_never_repeat_across_messages(1000 consecutive generators, no duplicate${uuid}).🤖 Generated with Claude Code