Repository navigation
[Backport v10.0] Fix: Install nav2_mppi_controller 1.3.13 from a PickNik-hosted deb instead of ros2-testing - #896
Merged
Merged
Conversation
|
Consider whether the change should land upstream in Overlapping files
|
JWhitleyWork
marked this pull request as ready for review
September 3, 2026 21:43
…lock The backport bot left conflict markers in the Dockerfile because v10.0 never carried the #889 ros2-testing block (its counterpart #840 was closed unmerged). Keep the #895 content verbatim; the resolved file is byte-identical to v10.1's Dockerfile. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qEhg4Y4v3R1cJCJeYq8Jj
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #895 to
v10.0.Backport notes
[written by AI]
v10.0never carried the earlierros2-testingblock from Fix: Install nav2_mppi_controller 1.3.13 from ros2-testing and enable MPPI open_loop in hangar_sim #889 (itsv10.0counterpart, Fix: Enable MPPI open_loop to restore hangar_sim nav speed #840, was closed unmerged), and it committed the Dockerfile with conflict markers. That is what failedpre-commit(hadolint:Dockerfile:80:1 unexpected '<'). The follow-up commit removes the three marker lines and keeps the Fix: Install nav2_mppi_controller 1.3.13 from a PickNik-hosted deb instead of ros2-testing #895 content; the resolvedDockerfileis byte-identical tov10.1's.v10.0has nodocker/keys/directory, so there is nothing to delete, and itsMOVEIT_PRO_BASE_IMAGEdefault resolves to the samepicknikciuser/moveit-pro:main-jazzytag asv10.1.src/hangar_sim/params/nav2_params.yamlonv10.0does not set MPPIopen_loop(that parameter change, Fix: Enable MPPI open_loop to restore hangar_sim nav speed #840, was closed). With this PR thev10.0image installsnav2_mppi_controller1.3.13 but nothing uses the new parameter, so the speed fix from moveit_pro#21202 does not land onv10.0unless the parameter is backported too. This PR does not add it.Verification on the resolved file:
pre-commit run --files Dockerfilepasses, including hadolint.docker buildof thenav2-mppi-debsstage plus the installRUNon top ofpicknikciuser/moveit-pro:main-jazzyinstallsros-jazzy-nav2-mppi-controller 1.3.13-1noble.20260903.032340with dependencies from the snapshot, holds it, passes theldd -rgate on both shipped libraries, and leaves no deb or temp file in the image.Release notes
nav2_mppi_controller1.3.13 is installed in thev10.0workspace image from a PickNik-hosted deb with a pinned checksum.Claude agent checks
Reviewed candidate:
761a7ffdonbackport-895-to-v10.0, basev10.0@fcb2f0fa, changed paths:Dockerfileonly.code-reviewerv10.1file), stage before base and install before rosdep, nothingv10.0-specific conflicts.platform-architect-bot,security-auditor(mechanical conflict-marker removal; the resulting file is byte-identical to thev10.1Dockerfile both bots reviewed on Fix: Install nav2_mppi_controller 1.3.13 from a PickNik-hosted deb instead of ros2-testing #895)roboticist-bot,frontend-noah-bot,documentation-bot,licensing-privacy-bot,compatibility-bot,sonar-bot,test-runner(same reasons as Fix: Install nav2_mppi_controller 1.3.13 from a PickNik-hosted deb instead of ros2-testing #895)🤖 Generated with Claude Code
https://claude.ai/code/session_014qEhg4Y4v3R1cJCJeYq8Jj