Skip to content

Replace more instances of KdTreeFLANN and pcl::search::KdTree - #6347

Merged
larshg merged 1 commit into
PointCloudLibrary:masterfrom
mvieth:nanoflann_default2
Oct 4, 2025
Merged

larshg merged 1 commit into
PointCloudLibrary:masterfrom
mvieth:nanoflann_default2

Conversation

@mvieth

@mvieth mvieth commented Sep 20, 2025 •

Copy link
Copy Markdown
Member

Follow-up of #6332

@mvieth
mvieth force-pushed the nanoflann_default2 branch 4 times, most recently from 98c1b52 to 0853bdf Compare September 23, 2025 19:21
@mvieth
mvieth marked this pull request as ready for review September 26, 2025 14:04
@mvieth mvieth added changelog: enhancement Meta-information for changelog generation module: search labels Sep 26, 2025
@mvieth
mvieth requested a review from Copilot October 4, 2025 13:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR continues the migration from deprecated PCL search interfaces by replacing more instances of KdTreeFLANN and pcl::search::KdTree with the newer pcl::search::autoSelectMethod API. This follows up on PR #6332 to modernize search method selection across the PCL codebase.

  • Replaces manual search tree instantiation with automatic method selection
  • Updates include statements to use pcl/search/auto.h instead of specific tree headers
  • Modifies logic to leverage the Purpose enum for optimized search method selection

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
visualization/src/common/io.cpp Replaces KdTreeFLANN with autoSelectMethod for nearest neighbor search
tracking/include/pcl/tracking/impl/nearest_pair_point_cloud_coherence.hpp Updates search initialization logic and includes
test/keypoints/test_iss_3d.cpp Adds missing kdtree include for tests
surface/include/pcl/surface/impl/surfel_smoothing.hpp Replaces organized/kdtree conditional with autoSelectMethod
surface/include/pcl/surface/impl/mls.hpp Updates MLS search initialization and control flow
segmentation/include/pcl/segmentation/impl/segment_differences.hpp Simplifies search tree initialization
segmentation/include/pcl/segmentation/impl/seeded_hue_segmentation.hpp Updates search method selection
segmentation/include/pcl/segmentation/impl/grabcut_segmentation.hpp Simplifies GrabCut search initialization
segmentation/include/pcl/segmentation/impl/extract_labeled_clusters.hpp Updates cluster extraction search logic
registration/include/pcl/registration/ppf_registration.h Updates member variable type declaration
registration/include/pcl/registration/impl/ppf_registration.hpp Updates PPF registration search initialization
recognition/include/pcl/recognition/ransac_based/trimmed_icp.h Converts TrimmedICP to use new search interface
keypoints/include/pcl/keypoints/impl/sift_keypoint.hpp Adds missing kdtree include
keypoints/include/pcl/keypoints/impl/keypoint.hpp Updates base keypoint search initialization
keypoints/include/pcl/keypoints/impl/harris_6d.hpp Converts Harris6D corner refinement to new search API
features/include/pcl/features/impl/statistical_multiscale_interest_region_extraction.hpp Updates feature extraction search method
apps/3d_rec_framework/include/pcl/apps/3d_rec_framework/feature_wrapper/local/local_estimator.h Simplifies uniform sampling search initialization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mvieth
mvieth requested a review from larshg October 4, 2025 13:31
@larshg
larshg merged commit 3968dd4 into PointCloudLibrary:master Oct 4, 2025
13 checks passed
@mvieth
mvieth deleted the nanoflann_default2 branch October 4, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Meta-information for changelog generation module: search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants