Skip to content

perf: keep the pre-launch file sweep off the runtime threads - #1063

Merged
LynithDev merged 2 commits into
Polyfrost:mainfrom
tunaseckin:fix/file-sweep-off-runtime
Nov 1, 2026
Merged

LynithDev merged 2 commits into
Polyfrost:mainfrom
tunaseckin:fix/file-sweep-off-runtime

Conversation

@tunaseckin

Copy link
Copy Markdown
Contributor

game_files_missing stats every library and spot-checks the asset tree, and it ran directly on an async task. plan_downloads does the same kind of sweep on the blocking pool, and its doc comment explains why.

VersionInfo is not Clone, so this wraps the call in block_in_place rather than moving it to spawn_blocking. The launcher runs a multi-thread runtime and no test reaches the launch path, so the current-thread panic case does not come up.

game_files_missing stats every library and spot-checks the asset tree,
and it ran straight on an async task. plan_downloads does the same kind
of sweep and its doc comment says why it belongs on the blocking pool.

VersionInfo is not Clone, so this uses block_in_place rather than
spawn_blocking. The launcher's runtime is multi-threaded, and no test
reaches the launch path.
@LynithDev
LynithDev merged commit 83cef5d into Polyfrost:main Nov 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants