Repository navigation
perf: keep the pre-launch file sweep off the runtime threads - #1063
Merged
Merged
Conversation
game_files_missing stats every library and spot-checks the asset tree, and it ran straight on an async task. plan_downloads does the same kind of sweep and its doc comment says why it belongs on the blocking pool. VersionInfo is not Clone, so this uses block_in_place rather than spawn_blocking. The launcher's runtime is multi-threaded, and no test reaches the launch path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
game_files_missingstats every library and spot-checks the asset tree, and it ran directly on an async task.plan_downloadsdoes the same kind of sweep on the blocking pool, and its doc comment explains why.VersionInfois notClone, so this wraps the call inblock_in_placerather than moving it tospawn_blocking. The launcher runs a multi-thread runtime and no test reaches the launch path, so the current-thread panic case does not come up.