Repository navigation
Add JSON-RPC support to Registry resources - #1817
Merged
Merged
Conversation
Implement the persistent resource protocol with lifecycle validation, Registry operations, and native what-if support while retaining executable fallbacks. Add protocol and transport integration coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The tests leave DSC_RESTRICTED_PATH set, which can prevent discovery of the generated JSON-RPC-only manifests and cause reuse-enabled cases to exercise executable fallbacks or fail unexpectedly.
1 open issue
What changed in this PR
Adds reusable JSON-RPC support to the Windows Registry resources while retaining executable fallbacks.
Changes:
- Implements lifecycle handling, resource operations, schema retrieval, and native what-if.
- Shares offline-hive inheritance logic while preserving per-entry overrides and RegistryList ordering.
- Adds protocol and transport integration tests and documents both invocation modes.
| File | Description |
|---|---|
resources/registry/tests/registry.jsonrpc.tests.ps1 |
Tests JSON-RPC operations, offline hives, and both transports. |
resources/registry/src/types.rs |
Extracts shared offline-hive inheritance logic. |
resources/registry/src/main.rs |
Routes JSON-RPC invocation and uses shared inheritance logic. |
resources/registry/src/jsonrpc.rs |
Implements the protocol server, operation dispatch, and unit tests. |
resources/registry/src/args.rs |
Adds the jsonrpc subcommand. |
resources/registry/registry.dsc.manifests.json |
Declares JSON-RPC transport and what-if support. |
resources/registry/locales/en-us.toml |
Adds localized command help and protocol errors. |
docs/reference/resources/Microsoft/Windows/Registry/index.md |
Documents transports and RegistryList behavior. |
Review effort: Balanced
😁 Code Coverage ReportChanged Code Coverage98% (90%+ coverage)
🔵 Full Codebase Coverage83% (good)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Microsoft.Windows/RegistryandMicrosoft.Windows/RegistryList, retaining executable fallbacks._exist: falsedeletion; preserve RegistryList entry order and offline-hive inheritance with per-entry overrides.Validation
./build.ps1 -Project registry -Test -Clippy -Quiet