Repository navigation
Handle DELETE /user/scene/{id} so app routine deletion persists - #107
Merged
Merged
Conversation
Lash-L
reviewed
Sep 27, 2026
Contributor
|
TY @Ahmed-max! |
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle
DELETE /user/scene/{id}Deleting a routine in the Roborock app didn't persist. The app sends
DELETE /user/scene/{id}, but no rule matched it, so the request fell through to the catchall. The catchall returned{"ok": true}without changing the inventory, so the routine came back on the next refresh.Changes
delete_sceneinroutes/user/scene/service.py. It removes the scene fromscenes,home_scenesandscene_order.DELETE-only matcher and builder inroutes/user/scene/item.py, and register thedelete_scenerule inendpoint_rules.py.Testing
tests/test_scene_delete.py;uv run pytest -qpasses.