Repository navigation
Add qiskit-maestro - #1450
Open
qiskit-bot wants to merge 4 commits into
Open
Add qiskit-maestro#1450qiskit-bot wants to merge 4 commits into
qiskit-bot wants to merge 4 commits into
Conversation
Co-authored-by: stephendiadamo <stephendiadamo@users.noreply.github.com>
1 task done
Luciano Bello (1ucian0)
previously approved these changes
Nov 4, 2026
Luciano Bello (1ucian0)
left a comment
Luciano Bello (1ucian0)
left a comment
Member
There was a problem hiding this comment.
Thanks for the submission! Just a small non-blocker
| name = "qiskit-maestro" | ||
| submission_number = 1449 | ||
| url = "https://github.com/QoroQuantum/qiskit-maestro" | ||
| description = "Run Qiskit circuits, Sampler and Estimator on the Maestro simulator: statevector, MPS, stabilizer and more, on CPU or GPU." |
There was a problem hiding this comment.
It took me some times to realize what Maestro means in this context (maybe it is my latino mind talking):
Suggested change
| description = "Run Qiskit circuits, Sampler and Estimator on the Maestro simulator: statevector, MPS, stabilizer and more, on CPU or GPU." | |
| description = "Run Qiskit circuits, Sampler and Estimator on the Maestro simulator (qoro-maestro): statevector, MPS, stabilizer and more, on CPU or GPU." |
Luciano Bello (1ucian0)
marked this pull request as ready for review
November 4, 2026 14:59
| development_status = "4 - Beta" | ||
| status = "active" | ||
| maintainers = ["https://pypi.org/user/stephen.diadamo/"] | ||
| requires_qiskit = ">=1.1" |
There was a problem hiding this comment.
consider putting a cap in your qiskit dependency (more info) and Qiskit v1 is not longer maintained
qiskit>=2.0,<3
Luciano Bello (1ucian0)
dismissed
their stale review
November 4, 2026 15:04
some other issues to consider
| url = "https://github.com/QoroQuantum/qiskit-maestro" | ||
| description = "Run Qiskit circuits, Sampler and Estimator on the Maestro simulator: statevector, MPS, stabilizer and more, on CPU or GPU." | ||
| contact_info = "stephen@qoroquantum.de" | ||
| labels = ["tensor networks", "GPU", "HPC", "Hamiltonian simulation"] |
There was a problem hiding this comment.
Not fully sure about HPC, but I think provider should be there
Suggested change
| labels = ["tensor networks", "GPU", "HPC", "Hamiltonian simulation"] | |
| labels = ["tensor networks", "GPU", "provider", "Hamiltonian simulation"] |
|
Thank you for the review. Let me know if there's anything else to add. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nomination for: qiskit-maestro
By Stephen Diadamo (@stephendiadamo), via #1449