Repository navigation
fix: create a fresh for_in iterator for each subscription - #868
Open
AlvaroBalbin wants to merge 1 commit into
Open
AlvaroBalbin wants to merge 1 commit into
AlvaroBalbin wants to merge 1 commit into
Conversation
dbrattli
reviewed
Nov 2, 2026
| @@ -0,0 +1,84 @@ | |||
| """AI-assisted preservation controls for for_in's iterable semantics.""" | |||
Collaborator
There was a problem hiding this comment.
This comment is not helpful, please remove
|
coverage: 93.851% (+0.01%) from 93.841% — AlvaroBalbin:fix/audit-ReactiveX-RxPY-74f5d40341f8 into ReactiveX:master |
Collaborator
|
Thank you for fixing. Please move the tests to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed for_in sharing an exhausted iterator by creating the mapped iterator separately for each subscription, with AI assistance. I preserved the admitted regression unchanged and verified the repository's lint and type checks, and source and wheel builds.
The controller verified the unchanged regression failing before the fix and passing afterward. The full pytest suite passed locally (1717 passed, 10 skipped). All required repository policy checks passed. The fork CI gate passed on commit 6ff74e4; upstream CI is awaiting maintainer approval.
AI-assisted contribution using OpenAI Codex.