Skip to content

style: ruff-format virtual_atoms.py in rfd3 and rfd3na - #390

Merged
rclune merged 1 commit into
RosettaCommons:productionfrom
daylight-00:style/ruff-format-virtual-atoms
Oct 2, 2026
Merged

rclune merged 1 commit into
RosettaCommons:productionfrom
daylight-00:style/ruff-format-virtual-atoms

Conversation

@daylight-00

Copy link
Copy Markdown
Contributor

lint_production has been red on production since #377: its ruff format --diff step (ruff 0.8.3, the version pinned in pyproject.toml) flags the same two files on every run and the job stops there, so ruff check is skipped as well.

-                    #... Pad_atoms should never inherit fixed state
+                    # ... Pad_atoms should never inherit fixed state
...
-                        <whitespace only>
+

This applies the formatter to models/rfd3/src/rfd3/transforms/virtual_atoms.py and models/rfd3na/src/rfd3na/transforms/virtual_atoms.py, two lines each.

`lint_production` has failed on every run since RosettaCommons#377 because `ruff format --diff` (0.8.3, the pinned version) flags the same two files, and the job stops there before `ruff check`.

- Write the comment as `# ...` and empty the whitespace-only line below it, in both files.
- Formatting only: the AST of both files is unchanged, and `ruff format --diff` and `ruff check` over `src models tests` now pass.
Copilot AI balanced review requested due to automatic review settings October 2, 2026 08:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@rclune rclune left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rclune
rclune merged commit 94c78ab into RosettaCommons:production Oct 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants