Repository navigation
Conversation
`lint_production` has failed on every run since RosettaCommons#377 because `ruff format --diff` (0.8.3, the pinned version) flags the same two files, and the job stops there before `ruff check`. - Write the comment as `# ...` and empty the whitespace-only line below it, in both files. - Formatting only: the AST of both files is unchanged, and `ruff format --diff` and `ruff check` over `src models tests` now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint_productionhas been red onproductionsince #377: itsruff format --diffstep (ruff 0.8.3, the version pinned inpyproject.toml) flags the same two files on every run and the job stops there, soruff checkis skipped as well.This applies the formatter to
models/rfd3/src/rfd3/transforms/virtual_atoms.pyandmodels/rfd3na/src/rfd3na/transforms/virtual_atoms.py, two lines each.ruff format --diff src models testsnow reports 398 files already formatted andruff check src models testspasses (ruff 0.8.3), so the job should go green.