Repository navigation
Fix race in Parallel.start() that could exceed -j worker threads - #4935
Merged
Merged
Conversation
The initial worker was started outside tm_lock. The new thread could run _maybe_start_worker() before the main thread appended it to self.workers, see a stale count, and start another worker. This made test/option/stack-size.py intermittently report an extra "Setting stack size failed" warning. Hold tm_lock around the initial _start_worker() call. Also remove test/option/stack-size.py branches for Python versions without threading.stack_size, which are no longer supported. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Contributor
Author
|
@acmorrow - claude thinks it found a missing lock in Parallel. thoughts? |
bdbaddog
added
testsuite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial worker was started outside tm_lock. The new thread could run _maybe_start_worker() before the main thread appended it to self.workers, see a stale count, and start another worker. This made test/option/stack-size.py intermittently report an extra "Setting stack size failed" warning.
Hold tm_lock around the initial _start_worker() call.
Also remove test/option/stack-size.py branches for Python versions without threading.stack_size, which are no longer supported.
Co-Authored-By: Claude Haiku 5.5 noreply@anthropic.com
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).