Repository navigation
Add short git hash to Docker image tags - #865
Merged
Merged
Conversation
The artifact registry enforces tag immutability. A date-only tag collides when a build is retried or two builds start in the same minute. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ag_with_short_hash
yliu2-sc
approved these changes
Nov 5, 2026
svij-sc
approved these changes
Nov 6, 2026
kmontemayor2-sc
marked this pull request as ready for review
November 6, 2026 01:12
kmontemayor2-sc
requested review from
mkolodner-sc,
xgao4-sc and
zfan3-sc
as code owners
November 6, 2026 01:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docker image tags built from the
Makefilewere date-only (YYYYMMDD_HHMM). The artifact registry enforces tag immutability, so two builds of different commits in the same minute (or a retried build) collide and the push fails. Tags now include the short git hash, e.g.20261105_0302_483c299c, so each commit gets a unique tag.Approach
SHORT_GIT_HASH(fromgit rev-parse --short HEAD, empty outside a git repo, matching the existingGIT_HASHfallback) and a singleDOCKER_IMAGE_TAG?=${DATE}_${SHORT_GIT_HASH}default.src-cpu,src-cuda,dataflow-runtime,dev-workbenchimage names and themake integration_testimage tag atDOCKER_IMAGE_TAGinstead ofDATE.User-facing changes
make push_*_docker_image/make integration_testdefault to<name>:<date>_<shorthash>instead of<name>:<date>.DOCKER_IMAGE_TAGis a new?=override that flows to every image; existing overrides (DOCKER_IMAGE_*_NAME_WITH_TAGused bycreate_release.yml,INTEGRATION_TEST_CPU_IMAGE_TAGused by the PR workflows) keep working unchanged.Verification
20261105_0302_483c299c;DOCKER_IMAGE_TAG=custompropagates to all image names;INTEGRATION_TEST_CPU_IMAGE_TAG=12345.1still overrides only the integration image.🤖 Generated with Claude Code