Skip to content

Fix random test fails and improving docs - #139

Merged
bocharsky-bw merged 3 commits into
SymfonyCasts:1.xfrom
bocharsky-bw:fix-random-test-fails
Oct 23, 2026
Merged

bocharsky-bw merged 3 commits into
SymfonyCasts:1.xfrom
bocharsky-bw:fix-random-test-fails

Conversation

@bocharsky-bw

Copy link
Copy Markdown
Member

Follow up #137 to make tests more stable. Also improve docs section about the added feature

The tests that run a real binary downloaded it into their own directory and
deleted it right after it ran. On Windows a binary that just ran can stay
locked for a moment, so the cleanup randomly failed the Windows jobs.

The binaries are now downloaded once into tests/fixtures/var/binaries and
reused, which also saves ~10 downloads per run. As a safety net, the command
tests retry the temp dir cleanup a few times and don't fail when it can't be
removed, as every test has its own temp dir.
The other build tests now share an already downloaded binary, so add one
that goes through the download into the project, as "tailwind:init" sets
it up for most apps.
@bocharsky-bw

Copy link
Copy Markdown
Member Author

OK, 4 runs - no fails, should be much more stable now 🎉

@bocharsky-bw
bocharsky-bw merged commit e8eb440 into SymfonyCasts:1.x Oct 23, 2026
48 checks passed
@bocharsky-bw
bocharsky-bw deleted the fix-random-test-fails branch October 23, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant