Skip to content

feat: 解耦 MagicDrag 与 Manager 扩展点 - #4

Merged
wszxdhr merged 6 commits into
mainfrom
002-magicdrag-refactor
Jan 21, 2026
Merged

wszxdhr merged 6 commits into
mainfrom
002-magicdrag-refactor

Conversation

@wszxdhr

@wszxdhr wszxdhr commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 解耦 MagicDrag 与 Manager,通过 coordinator 统一分发跨 Tab 事件
  • 引入 className/channelName 注册表与冲突检测,并完善诊断日志
  • 新增跨 Tab 回调与同类实例广播测试覆盖

Testing

  • yarn test

wszxdhr and others added 5 commits January 21, 2026 12:03
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@coderabbitai

coderabbitai Bot commented Jan 21, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1a663236e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/magic-drag/MagicDragManager.ts Outdated
- 移除 handleExternalDragEnterTab 中错误的 sourceTabId 守卫,修复跨 Tab 进入时回调不被触发的问题
- 修复 ESLint sonarjs/public-static-readonly 错误:添加 readonly 修饰符
- 修复 TypeScript 类型错误:getClassName 访问级别从 protected 改为 public
- 更新 CHANGELOG 记录所有修复项
@wszxdhr
wszxdhr merged commit f4becb6 into main Jan 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant