test(db): cover source deletes for keys the source never held - #2008
Open
KyleAMathews wants to merge 1 commit into
Open
KyleAMathews wants to merge 1 commit into
KyleAMathews wants to merge 1 commit into
Conversation
A source may delete a key it does not hold, for example after its backend accepted an optimistic insert and deleted the row before the source streamed it. The optimistic-history driver dropped those deletes before the model or the Collection saw them, so the coverage map listed the case as open. The driver now writes them and counts them. The contract: the delete retires an accepted snapshot of the key, as any ordinary source publication does, and leaves an active request in place. main already behaves this way. Three pinned histories cover a queued, an immediate, and an in-handler delete after an accepted insert. A mutant that rejects a delete for a key absent from the source projection passes the old optimistic-history campaigns and fails the new ones and the pinned histories. Co-authored-by: Isaac <no-reply@databricks.com>
|
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe optimistic-history oracle now retains source deletes for keys absent from source state and counts them. Property tests cover absent-key deletes after accepted optimistic inserts. Documentation records the behavior, test histories, campaign results, and a limit involving active inserts. ChangesAbsent-Key Source Delete Coverage
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The added histories cover the intended delete behavior. No issue requiring a fix before merge was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
More templates
@tanstack/angular-db
@tanstack/browser-db-sqlite-persistence
@tanstack/capacitor-db-sqlite-persistence
@tanstack/cloudflare-durable-objects-db-sqlite-persistence
@tanstack/db
@tanstack/db-ivm
@tanstack/db-sqlite-persistence-core
@tanstack/electric-db-collection
@tanstack/electron-db-sqlite-persistence
@tanstack/expo-db-sqlite-persistence
@tanstack/node-db-sqlite-persistence
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/react-native-db-sqlite-persistence
@tanstack/react-router-with-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/tauri-db-sqlite-persistence
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 180 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 8.66 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds oracle coverage for a source delete of a key that the source never held. It changes no production code.
mainalready follows the contract below, and the new histories now check it.The case
A backend can accept an optimistic insert and then delete the row before the source streams it. The source then sends a delete for a key that it never held:
Contract
The oracle's opening prose now states this contract.
Why no test covered it
The optimistic-history driver dropped each delete for a key the source did not hold. Neither the model nor the Collection saw such a delete. The coverage map recorded the case as open after #1996.
What changes
Evidence
A hostile mutant rejects a sync delete for a key absent from the source projection.
A broader mutant drops any delete for a key absent from
syncedData. It does not distinguish this change: the old grammar already kills it through queued deletes of held keys.Limits
An immediate delete can arrive while the insert is still active. The accepted row then stays until the next source publication, because a source delete acknowledges no request. A separate change drops immediate sync batches, so this PR does not revisit that rule.
Verification
@tanstack/dbsuite: 244 files, 8,269 tests pass.tsc: clean on the changed files.This pull request and its description were written by Isaac.
Summary by CodeRabbit