Repository navigation
chore(deps): upgrade markstream-vue to 2.0.24 - #2492
Simon-He95 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
zerob13
left a comment
There was a problem hiding this comment.
Review: approved
This is a scoped dependency upgrade: markstream-vue 2.0.11 → 2.0.24, plus the four packages it owns in the lockfile (markstream-core, stream-markdown-parser, markdown-it-ts, @chenglou/pretext). Nothing else in the repo changes.
I verified the published packages, not just the diff:
- The package export map is identical between 2.0.11 and 2.0.24. Both worker entries (
katexRenderer.worker,mermaidParser.worker) and all three stylesheet entries still exist, so every import path DeepChat uses remains valid. - The
NodeRendererprop surface is unchanged. The type additions are additive only (clipboardWriter,fitPreviewHeight,estimatedPreviewHeightPx,markup, optionalmaxCharsonflush), so no call site needs updating. - CSS class names and
--ms-*custom properties used by DeepChat are unchanged. Only Vue scoped-style hashes differ, which is expected from a rebuild. - 2.0.24 is the current
latesttag on npm. pnpm install --frozen-lockfileresolves cleanly, sopackage.jsonand the lockfile agree.
Local verification at 5a28efb:
pnpm run typecheck:webpasses.- 8 relevant renderer suites pass (108 tests):
MarkstreamDomContract,MarkdownRenderer,ThinkContent,MessageBlockToolCall,markdownWorkerLifecycle,markstreamTailwindSource,AboutUsSettings,ReleaseNotes. - No new tests were added, which is correct for a dependency-only change.
Residual risk: this component renders every chat message and code block, so jumping 13 patch releases does touch core UI behavior (streaming, parsing, Mermaid/D2 previews). The automated tests cover the DOM contract but not the visual result. CI build and static already pass; test-main, test-renderer, and packaging are still running. Approval should not be read as replacing those checks.
No blocking findings.
Summary
markstream-vuefrom2.0.11to2.0.24(latest stable).markstream-core2.0.24,stream-markdown-parser1.2.25,markdown-it-ts1.1.3, and@chenglou/pretext0.0.9.Why
2.0.24brings the accumulated parser, streaming, and rendering fixes since2.0.11, including:a<b && c>d), footnotes, CJK emphasis, and list/thematic-rule boundariesNo breaking API changes for our integration:
NodeRenderer,CodeBlockNode,PreCodeNode,MermaidBlockNode,setCustomComponents,normalizeLanguageIdentifier,getLanguageIcon, the worker entry points, andsetStreamDiffsWorkerPoolare all unchanged. The peer dependency ranges remain compatible with our installed versions.Verification
pnpm install --frozen-lockfilepnpm run format:checkpnpm run lintpnpm run i18npnpm run typecheck:webandpnpm run typecheck:nodepnpm run test:renderer— 287/288 files and 2756/2757 tests passed; one unrelatedChatStatusBartest hit the 10s timeout under full-suite load and passed on isolated rerun (92/92).No UI changes, so no before/after layout is needed.
Summary by CodeRabbit