Skip to content

fix(ci): bootstrap Linux keyring for E2E - #322

Merged
Timpan4 merged 2 commits into
mainfrom
fix/ci-linux-keyring-e2e
Aug 8, 2026
Merged

Timpan4 merged 2 commits into
mainfrom
fix/ci-linux-keyring-e2e

Conversation

@Timpan4

@Timpan4 Timpan4 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • install D-Bus, gnome-keyring, and libsecret prerequisites for Linux Tauri E2E
  • run real suites inside a headless D-Bus session with Secret Service enabled
  • invalidate apt caches after changing package inputs

Why

Release run 31090700128 failed because WebKitGTK reported native credential storage unavailable in the private Argo CD tunnel E2E test. This keeps release E2E strict and fixes the runner environment instead of bypassing credential-storage coverage.

Validation

  • Ruby YAML parse passed for both workflows
  • git diff --check passed
  • CI review found no workflow or matrix defects
  • Full Linux E2E requires GitHub Actions runner

@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Timpan4, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9bfe4cb3-b3a1-4cf9-bf11-8552c43bae46

📥 Commits

Reviewing files that changed from the base of the PR and between 644a011 and d260ce2.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .github/workflows/e2e.yml
  • .github/workflows/release.yml
  • package.json
📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Improved Linux end-to-end test execution with support for secure credential storage, D-Bus sessions, and graphical test environments.
    • Enhanced release validation reliability by ensuring test failures are correctly reported in CI pipelines.
    • Updated the Linux test environment dependencies and caching configuration for more consistent runs.

Walkthrough

The Linux E2E workflows now install desktop-session dependencies, refresh their apt-cache keys, and run Kubernetes tests inside D-Bus sessions with GNOME Keyring initialization, pipefail, and xvfb-run.

Changes

Linux E2E session setup

Layer / File(s) Summary
Linux runtime dependencies
.github/workflows/e2e.yml, .github/workflows/release.yml
The Linux E2E caches add D-Bus, GNOME Keyring, libsecret, and WebKit GTK packages. The cache keys use new versions.
Session-wrapped E2E execution
.github/workflows/e2e.yml, .github/workflows/release.yml
The E2E commands run inside dbus-run-session, start the GNOME Keyring secrets component, enable pipefail, and retain Xvfb and Kubernetes arguments.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A rabbit checks the Linux run,
With keyring, D-Bus, and Xvfb spun.
The tests hop through Kubernetes bright,
While pipefail keeps errors in sight.
New cache keys help the carrots flow—
E2E is ready to go! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding Linux keyring setup for E2E tests.
Description check ✅ Passed The description directly explains the CI dependency, session, cache, failure, and validation changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/e2e.yml:
- Line 64: Check the exit status of gnome-keyring-daemon before evaluating its
output at .github/workflows/e2e.yml lines 64 and 126 and
.github/workflows/release.yml line 207; fail the workflow when startup fails or
produces no valid shell code, rather than relying on eval alone.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 921f4884-8f4e-4adc-9a4c-f90023eac20b

📥 Commits

Reviewing files that changed from the base of the PR and between 74b83ed and 644a011.

📒 Files selected for processing (2)
  • .github/workflows/e2e.yml
  • .github/workflows/release.yml

Comment thread .github/workflows/e2e.yml Outdated
@codspeed

codspeed Bot commented Aug 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing fix/ci-linux-keyring-e2e (d260ce2) with main (74b83ed)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant