Skip to content

fix(deps): patch System.Security.Cryptography advisories - #527

Open
yordis wants to merge 2 commits into
masterfrom
yordis/fix-crypto-advisories
Open

yordis wants to merge 2 commits into
masterfrom
yordis/fix-crypto-advisories

Conversation

@yordis

@yordis yordis commented Nov 8, 2026 •

Copy link
Copy Markdown
Member
  • New advisories against System.Security.Cryptography.Pkcs and Xml up to 10.0.12 fail NuGet restore under warnings-as-errors, so every pull request is red.
  • The source generator tests pulled Pkcs 8.0.1 transitively, so they now reference the centrally pinned version directly.

Note

Low Risk
Dependency version bumps and an explicit test project reference address known crypto advisories; the Docker user flag change only affects container user setup.

Overview
Bumps centrally managed System.Security.Cryptography.Pkcs and System.Security.Cryptography.Xml from 10.0.10 to 10.0.14 so NuGet restore no longer fails on new security advisories when warnings are treated as errors.

EventStore.SourceGenerators.Tests now references System.Security.Cryptography.Pkcs explicitly so the project uses the pinned 10.0.14 version instead of an older transitive dependency.

Separately, the runtime Dockerfile creates a home directory for the eventstore user (--create-home instead of --no-create-home).

Reviewed by Cursor Bugbot for commit 53b231b. Bugbot is set up for automated code reviews on this repo. Configure here.

New Pkcs and Xml advisories fail restore under warnings-as-errors, blocking every pull request.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis requested a review from a team as a code owner November 8, 2026 07:26
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c9a71eb-ad39-4b26-b017-7bbc176c0759
Commits

Reviewing files that changed from the base of the PR and between d9a00b8 and 53b231b.

Files selected for processing: 3

  • Dockerfile
  • src/Directory.Packages.props
  • src/EventStore.SourceGenerators.Tests/EventStore.SourceGenerators.Tests.csproj
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cursor

cursor Bot commented Nov 8, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: adeb5ecb-45ce-432c-b4ab-d25c6e8ed757)

…ated

The .NET 10 runtime keeps named mutex state under the user's home
directory. The image created the eventstore user without one, so every
node exited at startup with an IOException from the database lock.
Creating the home directory lets the lock be acquired again.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Nov 8, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: ec876a18-1746-4dbd-b5ad-992e677ca2ca)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant