Skip to content

Fix test listmode - #1790

Draft
KrisThielemans wants to merge 2 commits into
UCL:masterfrom
KrisThielemans:fix_test_listmode
Draft

KrisThielemans wants to merge 2 commits into
UCL:masterfrom
KrisThielemans:fix_test_listmode

Conversation

@KrisThielemans

Copy link
Copy Markdown
Collaborator

Fix #1789

@KrisThielemans KrisThielemans added this to the v6.5.1 milestone Nov 12, 2026
@KrisThielemans KrisThielemans self-assigned this Nov 12, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 6 complexity · 2 duplication

Metric Results
Complexity 6
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@casperdcl casperdcl left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1791 worked for me

@KrisThielemans

Copy link
Copy Markdown
Collaborator Author

#1791 worked for me instead.

ok.

Meanwhile this (#1790) has an assert False which breaks on all non-ROOT builds?

i'd like to understand why it didn't fail before, hence a debug commit

@casperdcl casperdcl closed this in 8494154 Nov 12, 2026
@casperdcl casperdcl reopened this Nov 12, 2026
@casperdcl

Copy link
Copy Markdown
Collaborator

Reopening for debugging

@KrisThielemans

Copy link
Copy Markdown
Collaborator Author

Actual change is now obsolete due to #1791. We still need to get the test to run on GHA.

debug commit shows that it fails to read the ROOT file. Still no idea why (it works locally)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_listmode.py failing on when building on conda-forge

2 participants