Skip to content

Feature/fingerprint - #21

Merged
sdevriend merged 28 commits into
mainfrom
feature/fingerprint
Sep 29, 2026
Merged

sdevriend merged 28 commits into
mainfrom
feature/fingerprint

Conversation

@sdevriend

@sdevriend sdevriend commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Added new sub workflow bam_fp that can be used to generate a vcf file that contains the SNPs that are used for the fingerprint process.
Code is based on https://github.com/UMCUGenetics/DxNextflowFP/tree/develop
Testdata in: https://github.com/UMCUGenetics/DxNextflowTestData/tree/main/Subworkflows/bam_fp

@Jorisvansteenbrugge Jorisvansteenbrugge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first subworkflow addition! I've added a few suggestions to serve as finishing touches

Comment thread subworkflows/UMCUGenetics/bam_fp/tests/main.nf.test Outdated
Comment thread subworkflows/UMCUGenetics/bam_fp/tests/main.nf.test Outdated
Comment thread subworkflows/UMCUGenetics/bam_fp/tests/main.nf.test Outdated
Comment thread subworkflows/UMCUGenetics/bam_fp/tests/nextflow.config
Comment thread subworkflows/UMCUGenetics/bam_fp/main.nf Outdated
Comment thread subworkflows/UMCUGenetics/bam_variantcalling_intervals/main.nf
Comment thread subworkflows/UMCUGenetics/bam_variantcalling_intervals/meta.yml
Comment thread .github/workflows/nf-test.yml
Comment thread subworkflows/UMCUGenetics/bam_variantcalling_intervals/main.nf
Comment thread subworkflows/UMCUGenetics/bam_fp/tests/main.nf.test Outdated
Comment thread subworkflows/UMCUGenetics/bam_variantcalling_intervals/tests/main.nf.test Outdated

@Jorisvansteenbrugge Jorisvansteenbrugge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sdevriend
sdevriend merged commit 936de21 into main Sep 29, 2026
17 checks passed
@sdevriend
sdevriend deleted the feature/fingerprint branch September 29, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants