Repository navigation
Conversation
roccodev
force-pushed
the
feature/queue-chunk-unloads
branch
from
October 8, 2026 15:08
779ed31 to
36edee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, teleporting a player on 1.13.2 and below would sometimes cause this stuttering:
out.mp4
There are a few things at play here:
The issue can seemingly also be fixed by sending proto chunks (full chunk set to true, but zero bitmask) before each unload, however this leads to a chunk leak in 1.9.2 and below (the second value of
MultiplayerChunkCachein F3 does not reset because values are being replaced in a hash map without cleaning up the old ones). So I think this is the cleanest way for all client versions.This only delays chunk unloads, and only when it is safe to do so. I made it configurable cause it is a bit of a hack/tries to replicate old server behavior. Though if you guys are happy with the design I wouldn't mind having it enabled by default.
1.8 POV with the issue fixed:
out.mp4