Skip to content

Remove unused memof module - #28

Merged
tiye merged 1 commit into
mainfrom
chore/remove-unused-memof
Sep 23, 2026
Merged

tiye merged 1 commit into
mainfrom
chore/remove-unused-memof

Conversation

@tiye

@tiye tiye commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the unused memof/ entry from the Calcit Snapshot with calcit config rm-module.
  • Remove the matching calcit-lang/memof dependency from deps.cirru.

No application definition imports or calls memof; the remaining project files contain no memof references.

Validation

  • calcit query config confirms the default entry no longer includes memof/.
  • calcit edit format reports no formatting changes, and git diff --check passes.
  • Full local Calcit checks are blocked by missing .calcit/modules/respo.calcit and the protected global module-cache config; CI runs the strict check and build.

Summary by CodeRabbit

  • Chores
    • Updated the app’s internal package configuration.
    • No changes to user-visible features or behavior are included in this update.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ba010205-bdaa-4b0b-a1b8-575a964194e9

📥 Commits

Reviewing files that changed from the base of the PR and between 3e73377 and 771a924.

📒 Files selected for processing (2)
  • calcit.cirru
  • deps.cirru
💤 Files with no reviewable changes (1)
  • deps.cirru

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The package module list no longer includes memof/, and deps.cirru no longer lists calcit-lang/memof version 0.0.33.

Changes

memof configuration removal

Layer / File(s) Summary
Remove memof from configuration
calcit.cirru, deps.cirru
The package module list and dependency list no longer include memof.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 771a9

No tracked project files still reference memof, and its module and dependency entries were removed together. No merge-blocking risk from this change is identified; normal CI checks remain appropriate.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the unused memof module and dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tiye
tiye merged commit 07afbd4 into main Sep 23, 2026
1 check passed
@tiye
tiye deleted the chore/remove-unused-memof branch September 23, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant