Repository navigation
Migrate to stable Calcit 0.29 and typed WebGPU APIs - #1
Conversation
|
WebGPU-Art is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.
ℹ️ Recent review info
WalkthroughThe application is rewritten for the current Calcit code-entry format and Lagopus runtime APIs. The repository adds pinned build tooling and CI checks. Production asset uploads and rsync deployment run only when a main-branch workflow matches the current main revision. ChangesSyntax Cards application and delivery
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Actions as GitHub Actions
participant Vite as Vite build
participant Main as main branch
participant COS
participant Server as rsync destination
Actions->>Vite: build with public base URL
Actions->>Main: query current main SHA
alt SHA matches GITHUB_SHA
Actions->>COS: upload and verify frontend assets
Actions->>Server: run rsync deployment
else SHA differs
Actions->>Actions: skip production upload and deployment
end
Comment |
|
Production follow-up: PR run 38121525008 passed, but merged main run 38121584874 failed before upload with Missing required input: bucket. Actual action inputs COS_BUCKET, COS_SECRET_ID and COS_SECRET_KEY were all empty; server deployment was correctly not executed. The repository is private and WebGPU-Art uses GitHub Free. GitHub documents that organization-level secrets are not accessible to private repositories on GitHub Free: https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-secrets . Listing inherited secret names does not prove runtime availability. Please configure repository-level COS_BUCKET, COS_SECRET_ID, COS_SECRET_KEY and RSYNC_PRIVATE_KEY, then rerun this main run. No secret values were read, no credential/visibility changes were made, and the verification gate has not been bypassed. Language/type/build/browser migration is accepted; production completion remains pending repository secrets. |
Summary
Acceptance
Summary by CodeRabbit