Repository navigation
Apply VehicleDamageEvent.getDamage() for boats - #192
Merged
windcolor-dev merged 6 commits intoOct 22, 2026
Merged
Conversation
EntityBoat honored cancel but ignored event.getDamage(), so plugins could not change boat damage. Apply the event damage the same way EntityMinecartAbstract already does. Co-authored-by: xii69 <xii69@yahoo.com>
…/VehicleDamageEventBoatParityTest.java
Co-authored-by: xii69 <xii69@yahoo.com>
cursor
Bot
force-pushed
the
fix/boat-vehicle-damage-event
branch
from
October 14, 2026 21:11
2addb93 to
708f370
Compare
Correct "Apply VehicleDamageEvent.getDamage() for boats"
windcolor-dev
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Boats already fired
VehicleDamageEventand respected cancel, butevent.getDamage()was commented out with “TODO Why don't we do this?”. Plugins callingsetDamage()had no effect on boats. Minecarts already applied the event damage.What this changes
After the cancel check, apply
f = (float) event.getDamage()— same pattern as minecarts. Cancel still returns early with no damage.Why this is needed
If we fire the event, plugins should be able to change the damage. Leaving that line commented makes the API lie for boats only.
Testing
VehicleDamageEventBoatParityTest3/3; server tests green; package OK.