Repository navigation
Conversation
Contributor
Author
|
I'll check why this one failed the build |
Co-authored-by: xii69 <xii69@yahoo.com>
cursor
Bot
force-pushed
the
fix/nacho-windspigot-config-migration
branch
from
October 14, 2026 21:36
3cd57d9 to
7ad5328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The Nacho → WindSpigot config migration was half-done: migration code commented out, and when it did copy values they often stayed in memory instead of being written to
windspigot.yml. Operators with an oldnacho.ymlcould lose or confuse settings across the rename.What this changes
Adds
NachoConfigMigration: one-shot copy of overlapping options + world-settings into Wind YAML, flagsettings.migrated-from-nachoso later boots don’t overwrite operator edits, and world config prefers Wind after migration. Options Wind intentionally removed (e.g. ProtocolLib shim stuff) are not migrated.Why this is needed
This is Wind-owned unfinished work. Leaving dual configs unfinished is an ops footgun; finishing migration once and persisting it is the whole point of the rename.
Testing
NachoConfigMigrationTest5/5; knockback tests still green; compile OK.