Repository navigation
Conversation
Co-authored-by: xii69 <xii69@yahoo.com>
cursor
Bot
force-pushed
the
fix/windpvp-knockback-preset
branch
from
October 14, 2026 21:36
d226f89 to
09b9391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The default
windpvpknockback profile was still labeled WIP and only partly seeded. A bunch of knobs (friction, vertical limits, add-*, stop-sprint, etc.) silently fell back to field defaults, so “windpvp” wasn’t a complete, intentional preset. Also/kbwtap/add didn’t always save.What this changes
Introduces
KnockbackPresetssowindpvp(and kohi) set every knob explicitly. Seedswindpvponly if missing — won’t clobber an existingknockback.ymlsection. Runtime default stayskohifor Nacho compat. Fixes save on wtap/add.Why this is needed
Knockback is a core WindSpigot feature. Shipping a profile marked WIP with incomplete seeding is confusing for server owners and for anyone comparing profiles. This finishes the preset instead of pretending the TODO isn’t there.
Note: issue #126 (KB dying when a second player joins) is async knockback / separate from this preset work; maintainer already pointed at #174 for that.
Testing
KnockbackPresetsTest4/4; explosion KB tests 4/4; compile OK.