Repository navigation
Fix hanging entity obstruction break cause - #197
Merged
windcolor-dev merged 7 commits intoOct 15, 2026
Merged
Conversation
Classify HangingBreakEvent as OBSTRUCTION from full-BB getCubes collision instead of a single BlockPosition air sample, which missed large paintings and partial overlaps. Valid placements unchanged. Co-authored-by: xii69 <xii69@yahoo.com>
…HangingBreakCauses.java
…HangingBreakCausesTest.java
Co-authored-by: xii69 <xii69@yahoo.com>
cursor
Bot
force-pushed
the
fix/hanging-obstruction-cause
branch
from
October 14, 2026 21:11
54d1193 to
02ab84a
Compare
Correct "Fix hanging entity obstruction break cause"
Member
|
Looks good, thank you @xii69 and @kalibrieren |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
When a frame/painting couldn’t survive, we decided “obstruction vs physics” by checking a single block at the entity origin. Big paintings (or partial overlaps) can have air at the origin but still intersect solid cubes — so plugins often saw
PHYSICSinstead ofOBSTRUCTION.What this changes
Use the same full bounding-box cube check that
survives()already uses to decide obstruction, viaHangingBreakCauses. Placement rules themselves are unchanged; only the break cause gets accurate when the hanging is already invalid.Why this is needed
Wrong break cause changes how plugins react (some only cancel certain causes). Aligning cause with the real survival check avoids frames/paintings behaving inconsistently when clipped into blocks.
Testing
HangingBreakCausesTest5/5; server suite green; package OK.