Repository navigation
Conversation
Co-authored-by: xii69 <xii69@yahoo.com>
cursor
Bot
force-pushed
the
fix/send-chunk-change
branch
from
October 14, 2026 21:36
b9576a9 to
c570dc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
CraftPlayer.sendChunkChangethrewNotImplementedExceptionwith a TODO. Any plugin calling the documented API hard-crashed that path.What this changes
Implements it for 1.8 by parsing the old Packet51-style cuboid buffer and sending per-cell
PacketPlayOutBlockChange— same “fake blocks for one player, don’t change the world” idea assendBlockChange. Height limit updated 128→256.Why this is needed
Public API that always throws is worse than not having the method. This gives plugins a real 1.8-compatible behavior instead of a landmine.
Testing
Packet51CuboidTest13/13; server suite green; package OK.