Skip to content

fix: reference-geometry parameter not working with upper/mixed case secondary instance names - #866

Merged
lindsay-stevens merged 2 commits into
XLSForm:masterfrom
lindsay-stevens:refgeo-casing
Sep 30, 2026
Merged

lindsay-stevens merged 2 commits into
XLSForm:masterfrom
lindsay-stevens:refgeo-casing

Conversation

@lindsay-stevens

Copy link
Copy Markdown
Contributor

Fix for bug report in https://forum.getodk.org/t/58592
Test to more clearly document duplicate ref-geo behaviour per https://forum.getodk.org/t/57427/51

Why is this the best possible solution? Were any other approaches considered?

Expanded list of case-sensitive parameter names to include reference-geometry, so it can match any valid secondary instance name. Added tests to cover lower/upper/mixed case names for each output test case, to avoid regressions. Replaced original parameter name list with references to the param names, and added comment, to make it more obvious how they are related.

With these changes, the repro XLSForm provided in the forum thread converts without errors or warnings: input Reference geometry error.xlsx result Reference geometry error.xml.

What are the regression risks?

Should be none - this was a bug blocking upper or mixed case secondary instance names.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyxform tests and ruff check pyxform tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

- previously only lower-cased secondary instances could be used.
- as reported on https://forum.getodk.org/t/58592
- as described in test case comment, last copy wins
@lindsay-stevens lindsay-stevens added the needs testing ready for QA review label Sep 29, 2026

@lognaturel lognaturel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for getting right on that.

@lindsay-stevens
lindsay-stevens merged commit f2f91d9 into XLSForm:master Sep 30, 2026
14 checks passed
@lindsay-stevens
lindsay-stevens deleted the refgeo-casing branch September 30, 2026 02:58
@lindsay-stevens lindsay-stevens removed the needs testing ready for QA review label Sep 30, 2026
@lindsay-stevens lindsay-stevens mentioned this pull request Oct 1, 2026
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants