Repository navigation
fix: reference-geometry parameter not working with upper/mixed case secondary instance names - #866
Merged
Conversation
- previously only lower-cased secondary instances could be used. - as reported on https://forum.getodk.org/t/58592
- as described in test case comment, last copy wins
lognaturel
approved these changes
Sep 29, 2026
lognaturel
left a comment
Contributor
There was a problem hiding this comment.
Nice! Thanks for getting right on that.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for bug report in https://forum.getodk.org/t/58592
Test to more clearly document duplicate ref-geo behaviour per https://forum.getodk.org/t/57427/51
Why is this the best possible solution? Were any other approaches considered?
Expanded list of case-sensitive parameter names to include reference-geometry, so it can match any valid secondary instance name. Added tests to cover lower/upper/mixed case names for each output test case, to avoid regressions. Replaced original parameter name list with references to the param names, and added comment, to make it more obvious how they are related.
With these changes, the repro XLSForm provided in the forum thread converts without errors or warnings: input Reference geometry error.xlsx result Reference geometry error.xml.
What are the regression risks?
Should be none - this was a bug blocking upper or mixed case secondary instance names.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code