Repository navigation
Use centralized function/objects for all network access #591
Description
The network calls are scattered in many places and this is problem.
- this is technical debt
- we cannot log things easily Implement structured logging #590
- we should disable etags but this is in many places Disable Etag #321
- we cannot easily add proxy support at once Support for http/socks proxy #559
- we cannot implement API politeness at once Be polite to APIs #506 nginx import -> Name or service not known #568
Activity
abhi-kr-2100 commentedon Nov 21, 2022
I skimmed the code and found a
fetch_responseutility function invulnerabilities/utils.py, morefetch_*functions/methods purpose-built for their respective importers, andfetchmethods variousVersionAPIsubclasses.Before I try to fix this issue, I would like to know if this is what you're talking about as well? Perhaps, you know of some more?
My plan to fix this:
Fetcherclass (analogous to theImporterclass).Fetcherclass for an importer/VersionAPI as necessary.I'm contributing for the first time and will appreciate all the advice and constructive criticism I get get. :)
Implement centralized network access (Issue aboutcode-org#591) - Phase 1
sharwaripalve33-sketch commentedon Oct 17, 2026
Hi @pombredanne, I’m a student new to VulnerableCode and I’d like to help with this issue. I see #2113 was closed and #2234 is open and partially addresses this. Is a centralized network helper (a shared fetch function with error handling, retries, and one place for headers/proxy) still wanted? If so, I could start small: build the shared helper on top of #2234’s approach and migrate one importer, then open a PR for feedback. Does that fit what you have in mind, and is anyone currently working on it? If it’s free, I’d appreciate being assigned.