Skip to content

Generate only the types used by service signatures in C# client proxies - #26205

Merged
EngincanV merged 2 commits into
devfrom
maliming/csharp-proxy-types
Sep 30, 2026
Merged

EngincanV merged 2 commits into
devfrom
maliming/csharp-proxy-types

Conversation

@maliming

@maliming maliming commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

CSharpServiceProxyGenerator now generates only contract types reachable from service signatures. It uses API assembly metadata and client project assets to avoid regenerating referenced contract types.

Nested, generic, and same-named contract types are handled in generated DTOs and proxy signatures.

Copilot AI lite review requested due to automatic review settings September 23, 2026 07:38

This comment was marked as off-topic.

@maliming
maliming requested a lite review from Copilot September 23, 2026 07:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maliming maliming added this to the 10.8-preview milestone Sep 25, 2026
@maliming
maliming force-pushed the maliming/csharp-proxy-types branch from d91343e to 6e6f7ed Compare September 29, 2026 10:30
@abpframework abpframework deleted a comment from codecov Bot Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.05263% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.30%. Comparing base (c80c6f8) to head (6e4b1cf).
⚠️ Report is 52 commits behind head on dev.

Files with missing lines Patch % Lines
...viceProxying/CSharp/CSharpServiceProxyGenerator.cs 86.20% 34 Missing and 18 partials ⚠️
...c/ApiExploring/AbpApiDefinitionController_Tests.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #26205      +/-   ##
==========================================
+ Coverage   49.90%   50.30%   +0.39%     
==========================================
  Files        3842     3842              
  Lines      135458   135739     +281     
  Branches    10271    10318      +47     
==========================================
+ Hits        67597    68279     +682     
+ Misses      65823    65407     -416     
- Partials     2038     2053      +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming
maliming requested a review from EngincanV September 30, 2026 02:31
@EngincanV
EngincanV merged commit 420fd86 into dev Sep 30, 2026
4 checks passed
@EngincanV
EngincanV deleted the maliming/csharp-proxy-types branch September 30, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants