Skip to content

test(acp): drop the lint allows from the schema 1.17 and 1.20 tests - #515

Merged
benbrandt merged 1 commit into
mainfrom
test/schema-tests-without-lint-allows
Nov 21, 2026
Merged

benbrandt merged 1 commit into
mainfrom
test/schema-tests-without-lint-allows

Conversation

@benbrandt

Copy link
Copy Markdown
Member

tests/schema_1_17.rs and tests/schema_1_20.rs carried #![allow(dead_code, unused_imports)], because some helpers are only used by tests behind a feature.

  • schema_1_17.rs: assert_response_round_trips, assert_invalid_params, the JsonRpcResponse import and the v2 module are gated on the features whose tests use them.
  • schema_1_20.rs: assert_invalid_params moves into the v2 module, which is its only user. The unused JsonRpcResponse import is gone.

No test changed. Both files compile without warnings under every pair of crate features (cargo hack check --feature-powerset --depth 2, 154 combinations).

schema_1_15.rs, schema_1_18.rs and schema_1_19.rs have the same attribute from earlier PRs and are not touched here. Without it they produce 121 warnings across the single-feature builds, 101 of them in schema_1_19.rs.

Both files carried `#![allow(dead_code, unused_imports)]` because some
helpers are only used by tests behind a feature.

- schema_1_17.rs: `assert_response_round_trips` and
  `assert_invalid_params`, their imports, and the v2 module are gated on
  the features whose tests use them.
- schema_1_20.rs: `assert_invalid_params` moves into the v2 module, its
  only user, and the unused `JsonRpcResponse` import is gone.

Both files compile without warnings under every pair of crate features.
@benbrandt
benbrandt enabled auto-merge (squash) November 21, 2026 11:22
@benbrandt
benbrandt merged commit 2919c48 into main Nov 21, 2026
13 checks passed
@benbrandt
benbrandt deleted the test/schema-tests-without-lint-allows branch November 21, 2026 11:27
This was referenced Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant