Repository navigation
test(acp): drop the lint allows from the schema 1.17 and 1.20 tests - #515
Merged
Merged
Conversation
Both files carried `#![allow(dead_code, unused_imports)]` because some helpers are only used by tests behind a feature. - schema_1_17.rs: `assert_response_round_trips` and `assert_invalid_params`, their imports, and the v2 module are gated on the features whose tests use them. - schema_1_20.rs: `assert_invalid_params` moves into the v2 module, its only user, and the unused `JsonRpcResponse` import is gone. Both files compile without warnings under every pair of crate features.
benbrandt
enabled auto-merge (squash)
November 21, 2026 11:22
This was referenced Nov 21, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/schema_1_17.rsandtests/schema_1_20.rscarried#![allow(dead_code, unused_imports)], because some helpers are only used by tests behind a feature.schema_1_17.rs:assert_response_round_trips,assert_invalid_params, theJsonRpcResponseimport and the v2 module are gated on the features whose tests use them.schema_1_20.rs:assert_invalid_paramsmoves into the v2 module, which is its only user. The unusedJsonRpcResponseimport is gone.No test changed. Both files compile without warnings under every pair of crate features (
cargo hack check --feature-powerset --depth 2, 154 combinations).schema_1_15.rs,schema_1_18.rsandschema_1_19.rshave the same attribute from earlier PRs and are not touched here. Without it they produce 121 warnings across the single-feature builds, 101 of them inschema_1_19.rs.