Repository navigation
feat(acp): adopt schema 1.21.0 and re-export IndexMap - #516
Merged
Merged
Conversation
Schema 1.21.0 (schemas v1.34.1 / v2.0.0-beta.2) changes no message. It re-exports `IndexMap` from the schema crate and renames one docs link. - `agent_client_protocol::schema::IndexMap` is new. It is the map type of the schema's ordered maps, which needed a direct `indexmap` dependency to name since schema 1.20. - The core crate's `indexmap` dev-dependency and the workspace entry are gone. The tests use the re-export. - tests/schema_1_21.rs builds a v1 unknown state, a v2 unknown content block and the content of an accepted form from the re-exported type. - md/protocol-v2.md gains a Schema 1.21 section. The Schema 1.20 text and md/features.md no longer tell users to add `indexmap`.
benbrandt
enabled auto-merge (squash)
November 21, 2026 12:38
This was referenced Nov 21, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
agent-client-protocol-schemato 1.21.0 (schemas v1.34.1 / v2.0.0-beta.2). The release changes no message. It re-exportsIndexMapfrom the schema crate and renames one docs link.Changed
agent_client_protocol::schema::IndexMapis new. It is the map type of the schema's ordered maps: thefieldsof everyOther*variant,ElicitationSchema::properties,ElicitationAcceptAction::content, andSetProviderRequest::headers. Since schema 1.20, building one of these by name needed a directindexmapdependency.indexmapdev-dependency and the workspace entry are gone. The tests use the re-export.Tests and docs
tests/schema_1_21.rsbuilds a v1 unknown state, a v2 unknown content block and the content of an accepted form from the re-exported type: 3 tests with all features, 2 without. It has no#![allow], and the four touched test files compile without warnings under every pair of crate features.md/protocol-v2.mdgains a short Schema 1.21 section. The Schema 1.20 text andmd/features.mdno longer tell users to addindexmap.Checked, no change needed
Verification
just test(1,613 tests),cargo clippyandcargo clippy --all-targets --all-features --lockedwith no warnings, the three wasm clippy commands from CI, the nightly docs.rs build, the WASI docs build,cargo deny --all-features check,cargo fmt --checkandtypospass. I did not run the depth-2 feature powerset or the MSRV job locally.