Repository navigation
Conversation
✅ Deploy Preview for peaceful-beignet-dcf974 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's been a longstanding bug in the UI that makes horizontal scrolling on mobile a pain - but I've never cared enough to figure it out and fix it. Basically when you try to scroll horizontally, depending on the position and the exact vector of the gesture, it can either scroll horizontally or trigger a change in tab (e.g from All to Production) or trigger the side panel.
I was unable to find an existing GitHub issue for this.
Use the touchless prop, which seems to stop the unexpected activation of the tabs/side panel.
Screenshots
N/A - cannot be demonstrated by static screenshot. No layout changes.
Checklist
There is no test for this new behaviour because we'd have to introduce something like Puppeteer into the project - seems like overkill.
Unit tests pass. The Cypress e2e tests don't run on master as-is (Cypress 15 needs a cypress.config.js and possibly other things).
P.S. Thanks Nick - we've been using Alerta for over 8 years, it's been great, so simple, so low maintenance.