Repository navigation
Update NuGet packages and pin patched System.Security.Cryptography.Pkcs - #1752
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1752 +/- ##
======================================
Coverage 98% 98%
======================================
Files 515 515
Lines 24092 24092
======================================
Hits 23692 23692
Misses 400 400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CodeGen restore failed with NU1903 (warnings as errors) because NuGet.Protocol pulls in System.Security.Cryptography.Pkcs 8.0.1, which has known vulnerabilities (GHSA-846f-f764-76mx, GHSA-2fmv-rv2c-59x7). NuGet.Protocol 7.9.0 still depends on 8.0.1, so pin Pkcs 10.0.14 directly. Also bump packages to latest stable: - Microsoft.NET.Test.Sdk 18.11.0 - xunit.runner.visualstudio 4.0.1 - MinVer 8.0.0 - NuGet.Protocol 7.9.0 - Serilog 4.4.0 - System.Text.Json 10.0.14 - System.Collections.Immutable 10.0.14 - System.Reflection.Metadata 10.0.14 (Samples) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
88ad94a to
756537f
Compare
ubuntu-latest moved to 26.04, whose ICU ships CLDR 48. CLDR 48 changed the de-CH digit group separator from a right single quote to an ASCII apostrophe, so the "1’000′" cases fail on Linux. Set the separator explicitly so the tests no longer depend on the host's ICU version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
[claude-opus-5-5] via babysit-pr, on behalf of the PR operator. Reviewed head:
CI fix in this round: the two remaining Checks: Open for maintainer: Limits: the reviewer could not build or run tests locally and relied on CI logs. The vulnerability scan and net8/net9 results are from the author's local run. |
Fixes CI restore failure seen in #1751 (and on master):
Changes
System.Security.Cryptography.Pkcs10.0.14 in CodeGen. It comes in transitively viaNuGet.Protocol, and even 7.9.0 still depends on 8.0.1. Fixes GHSA-846f-f764-76mx and GHSA-2fmv-rv2c-59x7.MinVer 8's only breaking change rejects
MinVerDefaultPreReleasePhase, which is not used here.FeetInchesTestsseparator cases.ubuntu-latestmoved to 26.04, whose ICU ships CLDR 48, and CLDR 48 changed the de-CH separator from’to'. This is unrelated to the package bumps.Known limitation, not fixed here
With CLDR 48 data,
Length.TryParseFeetInchesreturns false for de-CH input that combines feet and inches using the ASCII apostrophe separator, such as1'000' 6". The apostrophe is also a feet abbreviation, and the lazy feet regex stops at the first one. Feet-only input such as1'000'still parses. The pinned test does not cover this case.Intentionally not updated
Microsoft.CodeAnalysis.CSharp4.14.0 (Modular): the Roslyn version sets the minimum compiler version for generator consumers.System.Text.Jsonand related build-only versions inUnitsNet.Modular/Directory.Packages.props: they mirror STJ's netstandard2.0 dependency floor.Verified locally
UnitsNet.slnx: build and all tests pass (net48, net8, net9, net10).UnitsNet.Modular.slnx(Platform=ProjectReferences, Release): build and 116 tests pass.dotnet list package --vulnerable: no findings.🤖 Generated with Claude Code