Skip to content

Fix 13283 needs test change note type vm - #21619

Closed
Tanay3183 wants to merge 2 commits into
ankidroid:mainfrom
Tanay3183:fix-13283-needs-test-change-note-type-vm
Closed

Tanay3183 wants to merge 2 commits into
ankidroid:mainfrom
Tanay3183:fix-13283-needs-test-change-note-type-vm

Conversation

@Tanay3183

Copy link
Copy Markdown
Contributor

Purpose / Description

Adding unit test coverage for closeDialogFlow in ChangeNoteTypeViewModel as requested by the @NeedsTest annotations.

Fixes

Partially addresses #13283

Approach

Added a new test case closeDialogFlow emits unit on success inside ChangeNoteTypeViewModelTest.kt.

How Has This Been Tested?

Ran the test locally using JUnit testing.

Learning (optional, can help others)

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • [ * ] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [ * ] You have commented your code, particularly in hard-to-understand areas
  • [ * ] You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@welcome

welcome Bot commented Aug 27, 2026

Copy link
Copy Markdown

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this hard conflict with your other open PR:

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Aug 27, 2026
@Tanay3183 Tanay3183 closed this Sep 2, 2026
@Tanay3183

Copy link
Copy Markdown
Contributor Author

Closing this PR to reopen a clean PR after merge conflicts

@Tanay3183
Tanay3183 deleted the fix-13283-needs-test-change-note-type-vm branch September 2, 2026 13:45
@david-allison

Copy link
Copy Markdown
Member

Hi, in future, please force push rather than opening more PRs

More PRs loses review history and gives maintainers more notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Has Conflicts Needs Author Reply Waiting for a reply from the original author Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants