Repository navigation
Conversation
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
david-allison
left a comment
Member
There was a problem hiding this comment.
Won't this hard conflict with your other open PR:
Contributor
Author
|
Closing this PR to reopen a clean PR after merge conflicts |
Member
|
Hi, in future, please force push rather than opening more PRs More PRs loses review history and gives maintainers more notifications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Adding unit test coverage for
closeDialogFlowinChangeNoteTypeViewModelas requested by the @NeedsTest annotations.Fixes
Partially addresses #13283
Approach
Added a new test case
closeDialogFlow emits unit on successinsideChangeNoteTypeViewModelTest.kt.How Has This Been Tested?
Ran the test locally using JUnit testing.
Learning (optional, can help others)
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.