Repository navigation
Feature/9348 add share identifier for batch - #330
Merged
utas-raymondng merged 2 commits intoOct 12, 2026
Merged
Conversation
shaunahu
marked this pull request as ready for review
October 12, 2026 03:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to aodn/ogcapi-java#358, which tags each download small or large and sets the Batch
shareIdentifieron the init job whenaws.batch.job.share.enabled=true.On a queue with a fair-share scheduling policy, AWS requires shareIdentifier on every submit and rejects submits without one. On a FIFO queue it rejects any submit that has one. So DAS has to set it on the prepare and collect jobs exactly when the init job has one.
entry_point.pyreads the init job's ownshareIdentifierfrom the existingdescribe_jobscall, logs it, and passes it tosubsetting.init.subsetting.initpasses it to both the prepare (array) and collect submits. Array children inherit it from the array parent.AWSHelper.submit_a_jobtakes an optionalshare_identifierand only addsshareIdentifierto the request when it's set.