Repository navigation
Conversation
|
@mcc0nnell please resolve the conflict |
cf26b37 to
df563d9
Compare
|
@IOhacker Conflict is resolved on the current signed head df563d9, and GitHub now reports the PR as mergeable. The resolution preserves upstream migrations 0254/0255 and renumbers this PR's idempotency-key migration to 0256; the JPA mapping remains length = 255. The new Fineract CI, PR Compliance, and Signed Commits Check runs are all blocked at GitHub's fork-workflow action_required approval gate with no jobs started. Could you please approve and run the workflows? |
|
@mcc0nnell Please make sure your commits are GPG signed. |
|
@mcc0nnell Please rebase onto the latest |
galovics
left a comment
There was a problem hiding this comment.
Hi @mcc0nnell, thanks for the PR. Widening the column and the @Column(length) together is the right shape.
- On MySQL
modifyDataTyperenders as a plainMODIFY COLUMN ... VARCHAR(255), which drops NOT NULL and defaults that are not restated. Ism_portfolio_command_source.idempotency_keyNOT NULL (see 0061, which restates it for MySQL)? If yes, acontext="mysql"changeset withMODIFY ... NOT NULLlike 0061 keeps it. Can you verify on both DBs? - The column is also part of a unique constraint / composite index. Does that still fit MySQL's index key length limit at 255 chars?
- We still don't validate the header length anywhere, so a 300-char key fails at the DB layer with a 500. Is a 400 at the handler level on your list?
- Pls make sure the commits are signed and CI is green once a maintainer approves the workflows.
Core Fineract currently accepts the configured idempotency header without applying a length constraint before command processing. The legacy
m_portfolio_command_source.idempotency_keycolumn and its JPA mapping are limited to 50 characters, while the newer JDBC command store usesVARCHAR(255).This change keeps the two command-storage paths consistent by:
m_portfolio_command_source.idempotency_keyfrom 50 to 255 characters via a new Liquibase migrationCommandSourceJPA mapping to matchThis is intentionally separate from #6231, which is hardening idempotency semantics for the newer command-processing path. This patch only removes a storage-width inconsistency in the legacy path.